Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout tweaks #1007

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Layout tweaks #1007

merged 3 commits into from
Jan 10, 2024

Conversation

VasylHryha
Copy link
Contributor

@VasylHryha VasylHryha commented Jan 5, 2024 •
edited
Loading

Description

close #991

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@VasylHryha VasylHryha self-assigned this Jan 5, 2024
@VasylHryha
Copy link
Contributor Author

new preview with fixed styles
image

@VasylHryha
Copy link
Contributor Author

Also, I liked previous breadcrumbs more than current, not sure why it's not ok to display parent route

@asvae
Copy link
Member

asvae commented Jan 10, 2024

@VasylHryha maybe we should roll them back, I found that design confusing as well

asvae
asvae approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asvae asvae merged commit 1447d56 into epicmaxco:develop Jan 10, 2024
@VasylHryha VasylHryha deleted the feat/layout_tweaks branch January 10, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvae asvae asvae approved these changes

@m0ksem m0ksem Awaiting requested review from m0ksem

Assignees

@VasylHryha VasylHryha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasylHryha @asvae