Revert "fix: some status updates are discarded by the status updater" #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4754 +/- ##
==========================================
+ Coverage 65.61% 65.63% +0.01%
==========================================
Files 211 211
Lines 31961 31969 +8
==========================================
+ Hits 20972 20983 +11
+ Misses 9750 9749 -1
+ Partials 1239 1237 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
zhaohuabing
commented
Nov 22, 2024
| updateChannel chan<- Update | ||
| } | ||
|
|
||
| // Send sends the given Update off to the update channel for writing by the UpdateHandler. | ||
| func (u *UpdateWriter) Send(update Update) { | ||
| // Non-blocking receive to see if we should pass along update. | ||
| u.updateChannel <- update | ||
| select { |
There was a problem hiding this comment.
This line can block reconciling
u.updateChannel <- update
There was a problem hiding this comment.
It seems that we got regression for #4336
https://github.com/envoyproxy/gateway/actions/runs/11965697450/job/33361599433?pr=4754
Messages: error waiting for Gateway status to have listeners matching expectations
An alternative approach is decouping the reconciler and gateway status updates: #4767
…4337)" This reverts commit 14830c7. Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
revert-4337-fix-missing-status-update
branch
from
045b2af
to
ec74784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4337
Fixes: #4685
Release Note: Yes