-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTING/WIP] deps/rust: Rename wasm32-wasi -> wasm32-wasip1 #36285
base: main
Are you sure you want to change the base?
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
requires resolution to bazelbuild/rules_rust#2782 /wait |
/lgtm deps |
/retest |
Signed-off-by: Ryan Northey <[email protected]>
seems like this needs a fix in proxy-wasm-rust-sdk ive tested proxy-wasm/proxy-wasm-rust-sdk#277 but that still gives the same warnings so probs more is needed there |
proxy-wasm/proxy-wasm-rust-sdk#277 only changes its own CI and text in examples, when using Cargo and not Bazel, so it won't have any effect on Envoy. But what are you trying to fix? I don't see any Wasm or Rust tests failing in this PR. If you're trying to get rid of warnings about |
yeah - trying to resolve the warnings i initially came to the conclusion that it needed to be resolved in rules_rust - but after updating that with what i thought should fix still seeing the same |
Do you mean bazelbuild/rules_rust#2894? I have no idea what that PR was trying to do, but you need significantly more changes to actually support a new target, and even more to modify existing platform. |
yeah - mostly as it closed bazelbuild/rules_rust#2782 which i thought was the issue |
Signed-off-by: Ryan Northey <[email protected]>
requires a cpp-host update at least i think |
Signed-off-by: Ryan Northey <[email protected]>
I don't think so? There is nothing host-related in there, at least if you ignore Wasmtime. In any case, you forgot to update checksum, which is why the tests are failing. |
apologies - i didnt push my latest local change - this was the error about cpp-host ERROR: Error computing the main repository mapping: at /src/workspace/envoy/bazel/repositories_extra.bzl:4:6: at /home/worker/.cache/bazel/_bazel_worker/f704bab1b165ed1368cb88f9f49e7532/external/proxy_wasm_cpp_host/bazel/cargo/wasmtime/remote/crates.bzl:15:6: Every .bzl file must have a corresponding package, but '@rules_rust//crate_universe/private:crates_vendor.bzl' does not have one. Please create a BUILD file in the same or any parent directory. Note that this BUILD file does not need to do anything except exist.
Loading: i didnt look too far what caused it |
No description provided.