Skip to content

Commit

Permalink
header-parser: fix return value check (#37371)
Browse files Browse the repository at this point in the history
Followup fix for PR #36919.
Detected by an internal fuzzer.

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Adi Suissa-Peleg <[email protected]>
  • Loading branch information
adisuissa authored Nov 26, 2024
1 parent 868d371 commit c425fcf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion source/common/router/header_parser_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ std::string HeaderParser::translateMetadataFormat(const std::string& header_valu
new_format = format_or_error.value();
for (size_t i = 1; i < array_or_error.value().size(); i++) {
auto string_or_error = array_or_error.value()[i]->asString();
if (!format_or_error.status().ok()) {
if (!string_or_error.status().ok()) {
return header_value;
}
absl::StrAppend(&new_format, ":", string_or_error.value());
Expand Down

0 comments on commit c425fcf

Please sign in to comment.