Skip to content

Commit

Permalink
Adds logger id for dynamic_modules (#37296)
Browse files Browse the repository at this point in the history
Commit Message: Adds logger id for dynamic_modules
Additional Description:

This commit adds a logger_id for the core dynamic_modules extension.

*
https://github.com/envoyproxy/envoy/tree/main/source/extensions/dynamic_modules
*
https://github.com/envoyproxy/envoy/tree/main/source/extensions/filters/http/dynamic_modules

This is to mainly avoid unnecessarily requesting review from logger
owners into
dynamic_modules PRs just for adding one line.


Risk Level: low
Testing: none
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

---------

Signed-off-by: Takeshi Yoneda <[email protected]>
  • Loading branch information
mathetake authored Nov 25, 2024
1 parent 256f107 commit 684407e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion source/common/common/logger.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ const static bool should_log = true;
FUNCTION(wasm) \
FUNCTION(websocket) \
FUNCTION(golang) \
FUNCTION(stats_sinks)
FUNCTION(stats_sinks) \
FUNCTION(dynamic_modules)

// clang-format off
enum class Id {
Expand Down

0 comments on commit 684407e

Please sign in to comment.