1.9.46 버전업 #666
1.9.46 버전업 #666
Conversation
…nto develop-hw
…을 제거하거나 변경하면 즉시 반영됨
analog A3/A4 fix
[로보트리] 신규 하드웨어 추가 및 기존 하드웨어 코드 컨벤션 정리
센서데이터의 Digital 타입 수신 적용 센서스틱 삭제
[네오피아] 버그 수정
analog port fix
Develop hw
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
app/modules/robotry_parodule.js|138 col 21| Closing curly brace does not appear on the same line as the subsequent block.
app/modules/robotry_parodule.js|149 col 13| Closing curly brace does not appear on the same line as the subsequent block.
app/modules/robotry_parodule.js|151 col 21| 'readData' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|160 col 13| 'self' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|165 col 48| Unexpected function expression.
app/modules/robotry_parodule.js|165 col 56| Unexpected space before function parentheses.
app/modules/robotry_parodule.js|174 col 13| 'self' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|175 col 13| 'cmdDatas' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|176 col 13| 'getDatas' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|177 col 13| 'setDatas' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|178 col 13| 'time' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|185 col 17| 'setKey' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|186 col 28| Unexpected function expression.
app/modules/robotry_parodule.js|186 col 36| Unexpected space before function parentheses.
app/modules/robotry_parodule.js|187 col 21| 'data' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|190 col 60| Missing semicolon.
app/modules/robotry_parodule.js|194 col 48| Missing trailing comma.
app/modules/robotry_parodule.js|195 col 30| Missing semicolon.
app/modules/robotry_parodule.js|203 col 9| Block must not be padded by blank lines.
app/modules/robotry_parodule.js|211 col 44| Missing trailing comma.
app/modules/robotry_parodule.js|212 col 22| Missing semicolon.
app/modules/robotry_parodule.js|219 col 9| Closing curly brace does not appear on the same line as the subsequent block.
app/modules/robotry_parodule.js|239 col 17| Closing curly brace does not appear on the same line as the subsequent block.
app/modules/robotry_parodule.js|251 col 9| Closing curly brace does not appear on the same line as the subsequent block.
app/modules/robotry_parodule.js|260 col 9| Closing curly brace does not appear on the same line as the subsequent block.
app/modules/robotry_parodule.js|269 col 21| Missing trailing comma.
app/modules/robotry_parodule.js|271 col 9| Closing curly brace does not appear on the same line as the subsequent block.
app/modules/robotry_parodule.js|278 col 13| 'datas' is never reassigned. Use 'const' instead.
app/modules/robotry_parodule.js|280 col 24| Unexpected function expression.
app/modules/robotry_parodule.js|280 col 32| Unexpected space before function parentheses.
app/modules/robotry_parodule.js|296 col 19| Missing semicolon.
app/modules/robotry_parodule.js|297 col 15| Missing semicolon.
app/modules/robotry_parodule.js|304 col 33| Newline required at end of file but not found.
app/modules/robotry_robitStage.js|47 col 61| Unexpected space before function parentheses.
app/modules/robotry_robitStage.js|49 col 35| Unexpected function expression.
app/modules/robotry_robitStage.js|49 col 43| Unexpected space before function parentheses.
app/modules/robotry_robitStage.js|65 col 31| Unexpected space before function parentheses.
app/modules/robotry_robitStage.js|125 col 54| Unexpected space before function parentheses.
app/modules/robotry_robitStage.js|144 col 34| Unexpected space before function parentheses.
app/modules/robotry_robitStage.js|154 col 49| Unexpected function expression.
app/modules/robotry_robitStage.js|154 col 57| Unexpected space before function parentheses.
app/modules/robotry_robitStage.js|160 col 46| Unexpected function expression.
app/modules/robotry_robitStage.js|160 col 54| Unexpected space before function parentheses.
app/modules/robotry_robitStage.js|180 col 37| Unexpected space before function parentheses.
app/modules/robotry_robitStage.js|324 col 32| Unexpected space before function parentheses.
| @@ -60,7 +60,28 @@ class ProboConnect extends BaseModule { | |||
| EC:0, | |||
| EEPR2:0, | |||
| EEPR1:0 | |||
There was a problem hiding this comment.
Missing trailing comma.
| EEPR1:0 | |
| EEPR1:0, |
| ROTATION_1:0, | ||
| ROTATION_2:0, | ||
| ROTATION_3:0, | ||
| ROTATION_4:0 |
There was a problem hiding this comment.
Missing trailing comma.
| ROTATION_4:0 | |
| ROTATION_4:0, |
| AXIS_Z1:0, | ||
| AXIS_Z2:0, | ||
| AXIS_Z3:0, | ||
| AXIS_Z4:0, | ||
| } |
There was a problem hiding this comment.
Missing trailing comma.
| } | |
| }, |
| @@ -273,13 +298,53 @@ class ProboConnect extends BaseModule { | |||
| this.InputData.EEPROM.EC = data[13]; | |||
| this.InputData.EEPROM.EEPR2 = data[14]; | |||
| this.InputData.EEPROM.EEPR1 = data[15]; | |||
|
|
|||
| this.InputData.Infinite.ROTATION_1 = (data[16]>>6)&0xC; | |||
There was a problem hiding this comment.
Operator '>>' must be spaced.
| this.InputData.Infinite.ROTATION_1 = (data[16]>>6)&0xC; | |
| this.InputData.Infinite.ROTATION_1 = (data[16] >> 6)&0xC; |
| @@ -273,13 +298,53 @@ class ProboConnect extends BaseModule { | |||
| this.InputData.EEPROM.EC = data[13]; | |||
| this.InputData.EEPROM.EEPR2 = data[14]; | |||
| this.InputData.EEPROM.EEPR1 = data[15]; | |||
|
|
|||
| this.InputData.Infinite.ROTATION_1 = (data[16]>>6)&0xC; | |||
There was a problem hiding this comment.
Operator '&' must be spaced.
| this.InputData.Infinite.ROTATION_1 = (data[16]>>6)&0xC; | |
| this.InputData.Infinite.ROTATION_1 = (data[16]>>6) & 0xC; |
| } | ||
| else if (data[0] == 0xff && data[1] == 0x44) { | ||
| //console.log(data); | ||
| let temp = ['', '', '', '']; |
There was a problem hiding this comment.
'temp' is never reassigned. Use 'const' instead.
| let temp = ['', '', '', '']; | |
| const temp = ['', '', '', '']; |
| else if (data[0] == 0xff && data[1] == 0x44) { | ||
| //console.log(data); | ||
| let temp = ['', '', '', '']; | ||
| let readData = data.subarray(2, data.length); |
There was a problem hiding this comment.
'readData' is never reassigned. Use 'const' instead.
| let readData = data.subarray(2, data.length); | |
| const readData = data.subarray(2, data.length); |
| self.paroduleData.MODULE[i] = readData[i]; | ||
| } | ||
| for (let i = 0; i < 4; i++) { | ||
| let value = self.paroduleData.MODULE[i]; |
There was a problem hiding this comment.
'value' is never reassigned. Use 'const' instead.
| let value = self.paroduleData.MODULE[i]; | |
| const value = self.paroduleData.MODULE[i]; |
| } | ||
| else if (value == this.MOTOR) { |
There was a problem hiding this comment.
Closing curly brace does not appear on the same line as the subsequent block.
| } | |
| else if (value == this.MOTOR) { | |
| } else if (value == this.MOTOR) { |
| } | ||
| else if (value == this.BUZZER) { |
There was a problem hiding this comment.
Closing curly brace does not appear on the same line as the subsequent block.
| } | |
| else if (value == this.BUZZER) { | |
| } else if (value == this.BUZZER) { |
https://oss.navercorp.com/entry/entry2/issues/7121