-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only store policy data once #2184
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
==========================================
- Coverage 71.22% 71.21% -0.02%
==========================================
Files 88 88
Lines 7490 7501 +11
==========================================
+ Hits 5335 5342 +7
- Misses 2155 2159 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Only collect the policy data once for each source group. Before this the data was duplicated for each component. https://issues.redhat.com/browse/EC-1027
@@ -400,7 +400,7 @@ func validateImageCmd(validate imageValidationFunc) *cobra.Command { | |||
close(jobs) | |||
|
|||
var components []applicationsnapshot.Component | |||
var manyData [][]evaluator.Data | |||
var evaluatorData [][]evaluator.Data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be []evaludator.Data
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intuitively, I think so, but I don't know if it adds any value and there's an acceptance test for it even, so I'd prefer to leave it alone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One followup could be that we only collect the data if --output=data
or the like was provided
I think this will do that. 0c29154 |
Only collect the policy data once for each source group. Before this the data was duplicated for each component.
https://issues.redhat.com/browse/EC-1027