Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #2177

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Remove dead code #2177

merged 1 commit into from
Nov 21, 2024

Conversation

lcarva
Copy link
Member

@lcarva lcarva commented Nov 19, 2024

These functions and variables are not used anywhere. Let's remove them to avoid collecting cruft.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.22%. Comparing base (3420832) to head (f8fe994).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
- Coverage   71.25%   71.22%   -0.04%     
==========================================
  Files          88       88              
  Lines        7512     7490      -22     
==========================================
- Hits         5353     5335      -18     
+ Misses       2159     2155       -4     
Flag Coverage Δ
generative 71.22% <ø> (?)
integration 71.22% <ø> (-0.04%) ⬇️
unit 71.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation_snapshot_image/application_snapshot_image.go 59.25% <ø> (+0.48%) ⬆️
internal/policy/policy.go 79.84% <ø> (+0.09%) ⬆️
internal/utils/helpers.go 70.00% <ø> (-3.34%) ⬇️
internal/utils/templates.go 52.77% <ø> (-1.28%) ⬇️
---- 🚨 Try these New Features:

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Linter also suggests removing more dead code

These functions and variables are not used anywhere. Let's remove them
to avoid collecting cruft.

Signed-off-by: Luiz Carvalho <[email protected]>
@lcarva lcarva merged commit e614d88 into enterprise-contract:main Nov 21, 2024
10 checks passed
@lcarva lcarva deleted the unused-stuff branch November 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants