Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Value_Type.Null, fix edge cases for read_many #11737

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Dec 2, 2024

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 2, 2024
@radeusgd radeusgd self-assigned this Dec 2, 2024
@radeusgd radeusgd force-pushed the wip/radeusgd/6281-value-type-null branch 2 times, most recently from 476409e to 8d22c04 Compare December 3, 2024 13:12
@radeusgd radeusgd force-pushed the wip/radeusgd/6281-value-type-null branch from c57057b to 22a2371 Compare December 3, 2024 17:22
@radeusgd radeusgd marked this pull request as ready for review December 3, 2024 17:23
@radeusgd
Copy link
Member Author

radeusgd commented Dec 3, 2024

Changes affect Snowflake so I'm running the Extra suite:

I expect it to fail because it is failing on develop. Yet I want to see if there are no more failures than what is expected.

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Extra Nightly Tests · edfeb06

@radeusgd
Copy link
Member Author

radeusgd commented Dec 3, 2024

Followup to fix Nothing * Nothing: #11751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a Value_Type.Null.
1 participant