-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run workflows depending on changed files #11723
Open
4e6
wants to merge
27
commits into
develop
Choose a base branch
from
wip/db/11579-run-ci-backend-when-sources-changed
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
CI: No changelog needed
Do not require a changelog entry for this PR.
-ci
-build-script
Category: build script
labels
Nov 29, 2024
🧪 Storybook is successfully deployed!📊 Dashboard:
|
Repo settings should be updated to reflect the changes. In the branch protection rules the following required checks should be removed:
renamed:
|
4e6
requested review from
jdunkerley,
AdRiley,
hubertp and
Frizi
as code owners
December 3, 2024 17:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-build-script
Category: build script
-ci
CI: No changelog needed
Do not require a changelog entry for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #11579
Changelog:
pull-request.yml
workflow. It calls the following checks depending on the files changed and unconditionally on the push to thedevelop
branch.gui-checks.yml
GUI Checksstorybook.yml
Storybookwasm-checks.yml
WASM Checks (previouslygui-tests.yml
GUI Check)engine-checks.yml
Engine Checks (previouslyscala-new.yml
Engine CI)gui-packaging.yml
GUI Packaging (previouslygui.yml
GUI Packaging)macOS
jobs withcontinue-on-error: true
to make them optional (currently they are not required to merge to PR). Even if they fail, the final report will be successful.Important Notes
This PR assembles all the workflows into a
pull-request.yml
which is dispatched on pull requests and calls all other existing workflows based on the files changed.GitHub visualization of the workflow is not very comprehensible, so I created this visualization.
The final report is required to gather the results of all (possibly skipped) checks. This will be the only required check to merge the PR.