Extend output port and remove selection halo #11715
Merged
+11
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
requested review from
Frizi,
farmaazon,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
farmaazon
approved these changes
Nov 29, 2024
| @@ -40,6 +40,7 @@ | |||
| - [Default values on widgets are displayed in italic][11666]. | |||
| - [The `:` type operator can now be chained][11671]. | |||
| - [Fixed bug causing Table Visualization to show wrong data][11684]. | |||
| - [No halo is displayed around components when hovering][11715]. | |||
There was a problem hiding this comment.
I think easier output port discoverability is worth mentioning
Frizi
approved these changes
Nov 29, 2024
|
This looks really good. Let's go ahead and remove the code we can always get from git history if we need to later. |
jdunkerley
pushed a commit
that referenced
this pull request
Dec 3, 2024
Closes #11507 - Output port area extended twice - Selection halo is removed (but most of the code is still there – I understood we don’t want to remove everything before testing) https://github.com/user-attachments/assets/4c6d7837-362e-4309-aa9b-5c0679d600e9 (cherry picked from commit ce1df4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #11507
no-halo.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.