-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More granular nesting for forms #11653
Open
MrFlashAccount
wants to merge
8
commits into
develop
Choose a base branch
from
wip/sergeigarin/better-nesting-for-forms
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFlashAccount
requested review from
PabloBuchu,
indiv0 and
somebody1234
as code owners
November 25, 2024 13:23
MrFlashAccount
added
CI: No changelog needed
Do not require a changelog entry for this PR.
g-dashboard
labels
Nov 25, 2024
🧪 Storybook is successfully deployed!📊 Dashboard:
|
app/gui/src/dashboard/components/AriaComponents/Form/components/useForm.ts
Outdated
Show resolved
Hide resolved
you can call it just once as like |
@somebody1234 could you please take a look at this PR? I'm bit struggling making the typescript happy. For example, here the allow passing the form instance from the parent form, e.g. use it as a part of the Subscription dialog. |
MrFlashAccount
added
the
CI: Keep up to date
Automatically update this PR to the latest develop.
label
Nov 26, 2024
jdunkerley
removed
the
CI: Keep up to date
Automatically update this PR to the latest develop.
label
Nov 27, 2024
somebody1234
force-pushed
the
wip/sergeigarin/better-nesting-for-forms
branch
from
November 27, 2024 09:48
b93fffa
to
538dda4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds more granular nesting for form components. Now you can pass callbacks in
useForm
and<Form />
componentThis PR also refactors the
UpsertDatalinkModal
andUpsertSecretsModal
and makes them more granular.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.