Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular nesting for forms #11653

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Nov 25, 2024

Pull Request Description

This PR adds more granular nesting for form components. Now you can pass callbacks in useForm and <Form /> component

This PR also refactors the UpsertDatalinkModal and UpsertSecretsModal and makes them more granular.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this Nov 25, 2024
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

🧪 Storybook is successfully deployed!

📊 Dashboard:

@somebody1234
Copy link
Contributor

you can call it just once as like const mutableForm = unsafeMutable(form). optional though, just suggesting it for readability's sake

@MrFlashAccount
Copy link
Contributor Author

@somebody1234 could you please take a look at this PR? I'm bit struggling making the typescript happy. For example, here the allow passing the form instance from the parent form, e.g. use it as a part of the Subscription dialog.

@MrFlashAccount MrFlashAccount added the CI: Keep up to date Automatically update this PR to the latest develop. label Nov 26, 2024
@jdunkerley jdunkerley removed the CI: Keep up to date Automatically update this PR to the latest develop. label Nov 27, 2024
@somebody1234 somebody1234 force-pushed the wip/sergeigarin/better-nesting-for-forms branch from b93fffa to 538dda4 Compare November 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants