Fix script popup #286
Fix script popup #286
Conversation
This is better because it considers the editor single window mode.
The TextEdit control node had the background color hardcoded to black.
Remove black ColorRect node. Also remove the Scroll node because the TextEdit containing the script can scroll automatically. Add a PanelContainer and Panel node. And remove unneeded MarginContainer nodes. This makes the layout work as expected when resizing the window. Previously the controls didn't shrink correctly (overflowing below the window).
Changing from TextEdit to CodeEdit shows a better background color, making it more readable.
|
Update, changing from TextEdit to CodeEdit displays a better / more readable background: |
|
This is a nice improvement though the code is still not always readable. For example, strings on a light theme are totally illegible:
I had the idea that it might be possible to reuse the syntax highlighting theme from the editor itself. It kind of is, with the caveat that it only works if you have at least one script open in the editor somewhere (even in a background tab). This is the result:
The colours are still not quite the same as in the real editor:
This is because we set the At any given point, the text color's alpha channel is clamped to the I'll push another patch to fix that which gives this result which I'm quite satisfied with:
|
If there is at least one script open in the editor, we can steal its syntax highlighter and apply it to the script window's CodeEdit control. Otherwise, we continue to use a built-in SyntaxHighlighter.
Because the CodeEdit's readonly property is set, TextEdit forces the alpha channel of all text rendered to be no higher than the alpha channel of the default colour for text in disabled controls, which is 0.65 as I type this. While we do not want the code in this popover to be editable, we do want it to be legible. Override the relevant font color on the control to set its alpha channel to 1, effectively disabling this undesired clamping.
|
BTW are you resizing the window when you take these screenshots? If not… I wonder why the window is so narrow on my system. The window allegedly has a default size of 750×750 pixels which is not the case either on your system or on mine. |
| for x in script_editor.get_open_script_editors(): | ||
| var control: Control = x.get_base_editor() | ||
| if control is TextEdit: | ||
| script_label.syntax_highlighter = control.syntax_highlighter |
| font_readonly_color.a = 1 | ||
| script_label.add_theme_color_override("font_readonly_color", font_readonly_color) |
There was a problem hiding this comment.
Good finding, I didn't know the read-only was doing that. Thanks for digging the sourcecode.
No I didn't, instead I added a lot of blocks to make it scroll. Hmm. |
Here is how it looks now with dark and light themes:
