Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows compatibility for tests #454

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add windows compatibility for tests #454

wants to merge 3 commits into from

Conversation

collerek
Copy link
Member

Add windows support for tests:

  • different path to venv scripts
  • aiopg needs a workaround with event loop setting on py3.8+

Should be reviewed after #453 is merged to highlight only relevant changes

@collerek collerek mentioned this pull request Jan 31, 2022
Merged
@aminalaee
Copy link
Member

Let's wait for the base branch to be dealt with so we can review this. But I like the windows compatibility approach anyway.

Maybe we can also add it to the GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee Awaiting requested review from aminalaee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@collerek @aminalaee