[WIP] Enable WASM_BIGINT by default #22993
Conversation
Enables by default by temporarily reducing required Safari version. Also includes bugfixes for WASM_BIGINT compatibility.
| @@ -49,7 +49,8 @@ var Module = typeof {{{ EXPORT_NAME }}} != 'undefined' ? {{{ EXPORT_NAME }}} : { | |||
| #include "polyfill/objassign.js" | |||
| #endif | |||
|
|
|||
| #if WASM_BIGINT && MIN_SAFARI_VERSION < 150000 | |||
| #if WASM_BIGINT && MIN_SAFARI_VERSION < 140100 | |||
| // TODO: Fix this back to 150000 | |||
| // See https://caniuse.com/mdn-javascript_builtins_bigint64array | |||
| #include "polyfill/bigint64array.js" | |||
There was a problem hiding this comment.
side note; I wasn't even aware we supported WASM_BIGINT without bigint64array (and I even said so in https://webassembly.org/features/). I don't know how many users we had for this; should we just remove the polyfill and don't support bigint for Safari 14?
| self.assertContained('emcc: error: using 64-bit arguments in EM_JS function without WASM_BIGINT is not yet fully supported: `foo`', err) | ||
|
|
||
| self.set_setting('WASM_BIGINT') | ||
| self.node_args += shared.node_bigint_flags(self.get_nodejs()) |
There was a problem hiding this comment.
I guess this line should no longer be needed since it will be the default now?
There was a problem hiding this comment.
The test still still executes the first part without bigint and the second part with it, I just use the command line flag instead of set_setting.
|
This is still WIP and has some tests and/or code under test that needs to be fixed up. I'll ping you again when it's ready or when I need other advice :) |
Enables by default by temporarily reducing required Safari version.
Also includes bugfixes for WASM_BIGINT compatibility.