Correctly set the token URL in the Oidc service #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the token URL was always set to the base URL. Oidc service now uses the token URL from the environment file. This problem is likely caused by the fact that this project template wasn't sufficiently tested with different base and token URLs.
|
Oh - I've always had the token and base the same url - and worked the same - so you 'can' host the token URL away from the angular url? OK - I'm trying to use the token based stuff outside the angular env at the moment, (separate API solution with a diff URL to separate it from the angular app - and I wanted to use the APIs URL... but it broke the angular stuff... Nice, I think you have solved my problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that even though I set the token URL in the environment file, it didn't take effect. I traced the problem and found that it is caused by a small oversight in the
oidc-helper.service.tsfile. Currently, the token URL was always set to the base URL. This change fixes that. The Oidc service now uses the token URL from the environment file.This problem is likely caused by the fact that this project template wasn't sufficiently tested with different base and token URLs.