Add option to set timeout on selfdiagnose #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 11, 2017 11:11
…thin which it will respond, although with a failure if the run could not complete due to timeout.
…econds) within which it will respond, although with a failure if the run could not complete due to timeout.
|
thank you for contributing, we will review the code |
|
Are you the queen? |
|
The pull requests looks good to me, except that the merge conflicts should be resolved. It would be good though if it would also be possible to configure a default timeout value (via java api and selfdiagnose.xml) where you can configure a default timeout. That way you can configure that there is always a timeout, even when none is given in the url. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource and servlet now support an optional timeoutMS parameter, which, if set, limits the total time of all checks together to the given timeout. If the timeout is exceeded a result containing a single error check is generated.