support empty rootURL with Ember CLI >= 5.0 #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until Ember CLI v5 the
baseURL
was set to'/'
ifrootURL
was an empty string. Since Ember CLI v5 thebaseURL
is not set anymore on theconfig.options
object at all. This change causes ember-cli-live-reload to break if applications setbaseURL = ''
in theconfig/environment.js
.Nullish coalescing operator should solve the issue as it does not fall back to
baseURL
ifrootURL
is an empty string.Please find a simple reproduction here: https://github.com/jelhan/ember-app-with-relative-root-url
ember serve
is working fine for the last commit using Ember CLI v4.12. If you go back one commit, which uses Ember CLI v5.0 it breaks with the error mentioned above.