This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Add throwOnError and throwOnWarn options #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey friends, any possibility to add this? Don't think it hurts anything. Just expands the features. |
|
when you use |
|
Right now if someone introduces an ESLint error the process hangs until the error is fixed. It still rebuilds on changes |
|
Hey friends, |
|
tbh I'm not convinced by this functionality. showing a "stack trace and error report" should be reserved for when something is really going terribly wrong, but not when linting fails 🤔 |
|
Well I understand it's not going to be wanted or needed by everyone or even most people. That's why it's an option. :) |
|
@Turbo87 I'd like to add a +1 for this option. We want eslint errors to be treated as regular JS syntax errors, so they are fixed immediately instead of being piled up. The option is absolutely a value-add. |
|
Given ember-cli/rfcs#121 I'm not sure how this would work in the future 🤔 |
|
@Turbo87 This addon will still be available though even if that RFC gets implemented? BTW great slides! Can't wait to see the recording for your talk |
|
the addon will still be here, but will likely not be maintained anymore at the same level as before, unless someone from the community steps up and takes over. |
Turbo87
pushed a commit
that referenced
this pull request
Oct 15, 2018
Bumps [ember-resolver](https://github.com/ember-cli/ember-resolver) from 4.1.0 to 5.0.1. <details> <summary>Changelog</summary> *Sourced from [ember-resolver's changelog](https://github.com/ember-cli/ember-resolver/blob/master/CHANGELOG.md).* > # Change Log > > ## [v4.5.6](https://github.com/ember-cli/ember-resolver/tree/v4.5.6) (2018-06-13) > [Full Changelog](ember-cli/ember-resolver@v4.5.5...v4.5.6) > > **Closed issues:** > > - An error occurred in the constructor for ember-resolver [\#234](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/234) > - emberResolverFeatureFlags\(\) calls project.config\(\) without an environment name [\#233](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/233) > - ember-cli-react/resolver not found [\#231](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/231) > - Add ember-cli-eslint [\#200](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/200) > > **Merged pull requests:** > > - cleanup yo [\#240](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/240) ([stefanpenner](https://github.com/stefanpenner)) > - Added config type to module unification config [\#239](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/239) ([chrism](https://github.com/chrism)) > - use flag EMBER\_CLI\_MODULE\_UNIFICATION [\#238](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/238) ([givanse](https://github.com/givanse)) > - Fixup linting issues. [\#236](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/236) ([rwjblue](https://github.com/rwjblue)) > - Update to [email protected] blueprint. [\#235](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/235) ([rwjblue](https://github.com/rwjblue)) > > ## [v4.5.5](https://github.com/ember-cli/ember-resolver/tree/v4.5.5) (2018-03-23) > [Full Changelog](ember-cli/ember-resolver@v4.5.4...v4.5.5) > > **Closed issues:** > > - \[4.5.3\] Build error [\#227](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/227) > - Support for RFC 297 - Deprecation of Ember.Logger [\#223](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/223) > > **Merged pull requests:** > > - \[RFC 297\] Updated to conditionally use console rather than using Ember.Logger [\#232](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/232) ([lupestro](https://github.com/lupestro)) > - Update module unification spec link [\#230](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/230) ([josemarluedke](https://github.com/josemarluedke)) > - Use build-time `project.isModuleUnification\(\)` instead of feature flag. [\#228](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/228) ([cibernox](https://github.com/cibernox)) > > ## [v4.5.4](https://github.com/ember-cli/ember-resolver/tree/v4.5.4) (2018-03-09) > [Full Changelog](ember-cli/ember-resolver@v4.5.3...v4.5.4) > > ## [v4.5.3](https://github.com/ember-cli/ember-resolver/tree/v4.5.3) (2018-03-09) > [Full Changelog](ember-cli/ember-resolver@v4.5.2...v4.5.3) > > **Closed issues:** > > - Namespaces [\#214](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/214) > > **Merged pull requests:** > > - Update MU trees: template-options is now template-compiler [\#226](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/226) ([cibernox](https://github.com/cibernox)) > > ## [v4.5.2](https://github.com/ember-cli/ember-resolver/tree/v4.5.2) (2018-03-05) > [Full Changelog](ember-cli/ember-resolver@v4.5.1...v4.5.2) ></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`6303c48`](ember-cli/ember-resolver@6303c48) release v5.0.1 🎉 - [`0ffc530`](ember-cli/ember-resolver@0ffc530) Merge pull request [#243](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/243) from ember-cli/remove-default-resolver - [`51f92e8`](ember-cli/ember-resolver@51f92e8) release v5.0.0 🎉 - [`df3ef4e`](ember-cli/ember-resolver@df3ef4e) Merge pull request [#244](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/244) from ember-cli/chores - [`1c40ceb`](ember-cli/ember-resolver@1c40ceb) Fix linting - [`340f2ca`](ember-cli/ember-resolver@340f2ca) upgrade eslint + qunit-dom - [`793ed30`](ember-cli/ember-resolver@793ed30) Disable not super important test for 3.3 test combat: - [`777bdf1`](ember-cli/ember-resolver@777bdf1) upgrade CLI - [`fa0302e`](ember-cli/ember-resolver@fa0302e) upgrades - [`d63ac09`](ember-cli/ember-resolver@d63ac09) update lockfile (fix node 10 issue) - Additional commits viewable in [compare view](ember-cli/ember-resolver@v4.1.0...v5.0.1) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=ember-resolver&package-manager=npm_and_yarn&previous-version=4.1.0&new-version=5.0.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. Dependabot will **not** automatically merge this PR because it includes a major update to a development dependency. --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
|
@Turbo87 I would still like this here. Even if the RFC gets implemented. Not everyone updates their app to the latest ASAP. Would help me out if the was merged in :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted this functionality so I added it.
The only caveat that I found was that this causes the build to fail and hang instead of fail and quit.
An example is:
As you can see the build failed but I wasn't thrown back to Terminal prompt but was instead stuck until I quit the current running process: On Windows with CTRL+C
Is this the wanted behavior or should this be fixed as well?