Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isVisible to StreamDeckSimulator #44

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add isVisible to StreamDeckSimulator #44

merged 1 commit into from
Nov 5, 2024

Conversation

finnvoor
Copy link
Contributor

Wanted to add a "Toggle simulator" button to debug settings and needed this

r-dent
r-dent approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@r-dent r-dent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @finnvoor!

Thanks for your PR! There is still a trailing_whitespace lint violation. If you could fixt this, we are good to go.

@r-dent
Copy link
Collaborator

r-dent commented Nov 5, 2024

Ah. I see, the violation is not even on you. 😅 Would you fix it anyway?

@finnvoor
Copy link
Contributor Author

finnvoor commented Nov 5, 2024

Ah. I see, the violation is not even on you. 😅 Would you fix it anyway?

done!

@r-dent r-dent merged commit eefc75b into elgatosf:main Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-dent r-dent r-dent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finnvoor @r-dent