API Structures Sidebar Not Alphabetized #526
Open
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @dsanders11 pls review this and guide me for any changes it needed |
erickzhao
requested changes
May 28, 2024
| @@ -178,6 +178,22 @@ export const createSidebar = async (root: string, destination: string) => { | |||
| prettierConfig | |||
| ); | |||
|
|
|||
| for (const id of Object.keys(sidebars)) { | |||
There was a problem hiding this comment.
issue(blocking): this won't work because the formattedSidebarString is parsed before we do any of the in-place sorting.
I also think we would want to only have this available for the API Structures categories, rather than every single sidebar category recursively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #408 added a sorting function in create-sidebar.ts to sort the sidebar in api