build: roll windows arc images automatically #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
arc-windows
branch
2 times, most recently
from
940addb
to
75dc08a
Compare
MarshallOfSound
force-pushed
the
arc-windows
branch
from
75dc08a
to
d4e29a8
Compare
VerteDinde
approved these changes
Nov 13, 2024
| @@ -2,3 +2,4 @@ | |||
| lib | |||
| node_modules | |||
| coverage | |||
| .envrc | |||
There was a problem hiding this comment.
Not a big deal, but do we need this line?
There was a problem hiding this comment.
Not really, I just ignore it in any project I touch that has local dev secrets. It's just because I use https://direnv.net/
jkleinsc
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids issues like we saw today where the windows ARC image drifted from what was "last" on main.
This logic is a bit fiddly but basically, we'll update the image SHA if:
mainimage is different to the current imageDockerfilefor "current" and "end" is non-empty (i.e. the windows dockerfile was actually updated)