chore!: upgrade got to 11.8.5

[clavin]

Bumps the dependency on got to version 11.8.5, fixing a dependabot alert. got also now includes its own type definitions, so the dependency on @types/got could be removed as well.

[malept]

I think this is a breaking change, as it raises the minimum Node.js version?

[malept]

Also for some reason the tests haven't been triggered

[clavin]

Ah, you're correct. The requirement for got v11 is "node": ">=10.19.0", whereas this package is still "node": ">=8.6". Nice catch!

[clavin]

Added the change to the minimum supported node version requirement to this PR as well just to make sure it doesn't get lost, if we choose to merge this.

[malept]

A couple of things:

1. The PR title should reflect that this is a breaking change: chore!: upgrade got to 11.8.5
2. I think you need to re-log-into CircleCI so that the tests will run. If I had to guess it's because of the multiple-orgs-that-require-SSO problem.

[clavin]

Looks like a dependency from this got version (compress-brotli) actually requires the min version to be >=12, even though got is itself only marked as >=10.19. Also have to bump the @types/node dependency here.

[vince-fugnitto]

Any update?

[malept]

See #224 (comment), merging this change needs to be coordinated properly.

[BlackHole1]

Based on #226 (comment) discussions. I think we should just upgrade instead of waiting for got to release a new patch version.

cc: @malept

[malept]

We're not waiting for got to release a new patch version.

[BlackHole1]

What are the reasons that are stopping this PR from being merged now? I want to push for this PR to be merged.

The most important reason, as I understand it so far, is the impact of the minimum node version

[BlackHole1]

If this impact is so important to us that we cannot merge this PR in a short time, is there another way, for example, if we fork got

[electron-bot]

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀