Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make appPath optional in MakerDMG options #3761

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

make appPath optional in MakerDMG options #3761

wants to merge 3 commits into from

Conversation

tanishqkancharla
Copy link

@tanishqkancharla tanishqkancharla commented Nov 16, 2024 •
edited
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

  • Remove the required appPath key and optional out path from MakerDMGOptions because it always gets overridden.

@tanishqkancharla tanishqkancharla requested a review from a team as a code owner November 16, 2024 23:20
@tanishqkancharla tanishqkancharla changed the title make appPath optional make appPath optional in MakerDMG options Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tanishqkancharla