Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log correct directory when hook moves artifacts #3730

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: log correct directory when hook moves artifacts #3730

merged 1 commit into from
Oct 8, 2024

Conversation

MarshallOfSound
Copy link
Member

If a postMake hook moves file around we shouldn't log the old wrong location. Using JSON.stringify to handle mutation instead of mapping in the hook.

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner October 8, 2024 05:28
felixrieseberg
felixrieseberg approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somebody ran notion desktop build 😉

@MarshallOfSound
Copy link
Member Author

Zero evidence for your baseless accusations... But yes 😆

@MarshallOfSound MarshallOfSound added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 7574b36 Oct 8, 2024
13 checks passed
@MarshallOfSound MarshallOfSound deleted the better-logging-for-moved-dist branch October 8, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrieseberg felixrieseberg felixrieseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @felixrieseberg