Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register-local-version protocol command #1652

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

samuelmaddock
Copy link
Member

Implements protocol handler for electron-fiddle://register-local-version/ to allow registering local versions.

Example request:

electron-fiddle://register-local-version/?name=feat%3A+service+worker+preload+scripts&version=35.0.0-dist&path=%2FUsers%2Fsamuelmaddock%2F.electron_build_tools%2Fartifacts%2Fpr_44411_darwin_arm64

This is intended to be used by build-tools as a way to quickly download build artifacts and test them in Fiddle.

Screen.Recording.2024-11-21.at.7.24.22.PM.mov

@coveralls
Copy link

coveralls commented Nov 22, 2024

Coverage Status

coverage: 87.594% (-0.01%) from 87.604%
when pulling 57a7625 on samuelmaddock:feat/register-local-version
into 3452e12 on electron:main.

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really elegant implementation!

src/main/utils/local-version.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants