refactor: improve credits page

[BlackHole1]

Before:

After:

[coveralls]

Coverage decreased (-0.004%) to 92.747% when pulling 02a9701 on BlackHole1:improve-credits into 4beeac3 on electron:main.

[ckerr]

Just my subjective opinion, but there's a lot more wasted space in the new version. Text descriptions in long profiles are no longer cut off mid-line, but the old version feels friendlier due to the larger avatar pictures.

Maybe keep the old version's avatars, but on the right-hand side of each contributor's box center the text and remove the vertical padding? E.g. in the old version Shelley, Mark, and Sam all have a blank line above their names and then their descriptions are cut off at the bottom. But top-aligning everything will look unbalanced for the short descriptions like Felix, David, and me, so maybe vertical centering the text would look better?

[BlackHole1]

@ckerr Yes, there will be far fewer avatars in the new version than before.

But there is a clear intention in doing so. This is because some people's bio is too long, resulting in an incomplete display. It affects the overall aesthetics and uniformity.

see: https://electronhq.slack.com/archives/CB389B7MH/p1650802514094799

---

You are right to consider.

Maybe we could have a default bio for people who don't have one?

[ckerr]

I might be biased because I have a shorter bio, but I kind of like the current appearance of the avatars. It's not a hill I'm going to die on; if other maintainers feel differently and want to outvote me by approving this that's fine 😄

But there is a clear intention in doing so. This is because some people's bio is too long, resulting in an incomplete display. It affects the overall aesthetics and uniformity.

Right, which is why in #1060 (comment) I suggested another way of making more screen real estate for the bio text

[BlackHole1]

@ckerr I think I would be willing to readjust in the way you have described. I've been busy lately though, so I may need to wait a few days. 😄