Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow simsimd again on Python 3.13 #2714

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Allow simsimd again on Python 3.13 #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beea0aa
Allow simsimd again on Python 3.13
pquentin Nov 20, 2024
b9074c0
Remove the importorskip calls
pquentin Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ dev = [
"nox",
"orjson",
"numpy",
"simsimd ; python_version<'3.13'",
"simsimd",
"pyarrow",
"pandas",
"mapbox-vector-tile",
Expand Down
4 changes: 0 additions & 4 deletions test_elasticsearch/test_server/test_vectorstore/test_vectorstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,8 +899,6 @@ def test_max_marginal_relevance_search_errors(
self, sync_client: Elasticsearch, index: str
) -> None:
"""Test max marginal relevance search error conditions."""
pytest.importorskip("simsimd")

texts = ["foo", "bar", "baz"]
vector_field = "vector_field"
embedding_service = ConsistentFakeEmbeddings()
Expand Down Expand Up @@ -942,8 +940,6 @@ def test_max_marginal_relevance_search(
self, sync_client: Elasticsearch, index: str
) -> None:
"""Test max marginal relevance search."""
pytest.importorskip("simsimd")

texts = ["foo", "bar", "baz"]
vector_field = "vector_field"
text_field = "text_field"
Expand Down
Loading