Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests #2276

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Fix integration tests #2276

merged 4 commits into from
Aug 23, 2023

Conversation

pquentin
Copy link
Member

No description provided.

@pquentin
Update test certificates
71999e0 
The ecertificates had expired in February 2023. The new ones were
generated using elasticsearch-certutil following those instructions:
https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html#docker-compose-file
@pquentin
Switch to pytest_asyncio.fixture
fadee11 
This is required now that strict mode is the default.
@pquentin
Copy link
Member Author

I am not worried about the Python 3.6 failures given #2268.

@pquentin
Copy link
Member Author

The test_rest_api_spec tests pass locally because ./ci/run-tests defaults to Elasticsearch 8.0, while CI defaults to Elasticsearch 8.10.

@pquentin
Stop testing Python 3.6 to please CI
7720258 
The actual removal will be done in another commit.
@pquentin pquentin requested a review from JoshMock August 22, 2023 18:46
JoshMock
JoshMock approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. I just dropped test-3.6 from the list of required checks for PRs being merged into main. There's some regex madness being used to apply branch protection to version branches that will still need to be unraveled soon. 😆

@pquentin pquentin merged commit 21a97dc into elastic:main Aug 23, 2023
8 checks passed
@pquentin pquentin deleted the clients-ci branch August 23, 2023 16:48
@pquentin pquentin mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshMock JoshMock JoshMock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @JoshMock