Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault when running update with --count=1 on a stack with more than one commit #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chriscz
Copy link
Collaborator

@chriscz chriscz commented Aug 22, 2024

This fixes #420

sortPullRequestsByLocalCommitOrder assumes that all commits in the stack will have a corresponding PR, which is not true.

Now I just need to figure out how to add a test for this ;)

@chriscz chriscz requested a review from ejoffe August 22, 2024 03:24
@chriscz chriscz self-assigned this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV running git spr update -c 1
1 participant