Adapt to coq/coq#19834 (removal of Loadpath.has_ml field) #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkySkimmer
force-pushed
the
no-ml-cwd
branch
2 times, most recently
from
97e57cb
to
82d38ac
Compare
|
Thanks! |
Although this removes instances of `has_ml = true`, `has_ml` is only used to send the path to the `add_dir` of the registered toplevel in Mltop. For coq-lsp the `has_dir` is noop (`coq/init.ml` line 76). So there should be no change in behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this removes instances of
has_ml = true,has_mlis only used to send the path to theadd_dirof the registered toplevel in Mltop. For coq-lsp thehas_diris noop (coq/init.mlline 76). So there should be no change in behaviour.