-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PARKED] waiting on ReadiumCSS ... Japanese settings in src/utils/fontList.ts #2252
base: develop
Are you sure you want to change the base?
Conversation
Great expert feedback, thank you very much :) |
Indeed, even with the settings in this pull request and running Thorium in the development environment, the font did not actually change. However, since I have not checked in detail, it is possible that this is a redundant specification or a strange setting. Another thing is that even before changing this font family, I have noticed that in vertical writing, there are cases where the leftmost sentence column is cut off. I haven't checked if it's already registered as an issue, but if not, I'd like to submit it as an issue later. (I don't know if this is a problem that can be fixed right away.) |
Thank you once again for looking into this. The navigator changes are actually directly related to the upstream ReadiumCSS project. @JayPanoz could you please take a look? Adding the recommended font faces to the local stack seems like a safe and sensible action. |
Related: readium/r2-navigator-js#79 |
…e pull request submitted to Readium-CSS.
…esktop into fix-fontList
After that, I changed my mind and decided to use "Yu Gothic Medium" for sans-serif, which is pre-installed in the Windows Japanese environment. For now, it seems to be the most effective fallback for readability.
I will commit after this. Note that the Yu font (Yu Mincho Medium) with a weight of 500 for serif is not pre-installed in the Windows Japanese environment. Therefore, I left the BIZ UD font as the preferred font for serif. |
Resolution: readium/readium-css#146 |
ReadiumCSS backport into navigator: readium/r2-navigator-js@17b86f2 |
Fixed via 3a79251 Thank you @peaceroad |
In past versions, when the language setting was set to Japanese, settings for horizontal/vertical Japanese fonts were added in FontList.ts in the font selection.
I think I currently have the following problem:
In this pull request, I hope to have solved the above problem to some extent.
(With Yu-Font's default settings, it appears a little thin and difficult to read.)
p.s.
Regarding specifying the font, I think it is difficult to solve the problem by simply specifying the font-family. For example, when Japanese is written vertically, ASCII characters may display rotating 90 degrees. In that case, you may also need to make adjustments using font-feature-settings.
If I have time...I would like to write about this in a separate issue at a later date.