Collect outgoing siblings for UnorderedGroup #2842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectOutgoingByContainer will stop collecting the next siblings if the next to it is mandatory, because it is expected to appear in that order. Handle unordered groups as well to collect all of the outgoing siblings.
|
For #2843 |
|
@rubenporras Can you please add a test for this? |
|
Do you have a suggestion how that could be tested? I are not very experienced with how the Xtext tests are structured and what can be easily done and what not. |
|
Sorry for the unreasonable delay. I just read the code here again, and I think it is reasonable. A test class to start with would be |
|
Sorry also for the long delay. We have been very busy upgrading Xtext due to the release of the old Xtext generator fragments. I might have time to look at the test now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectOutgoingByContainer will stop collecting the next siblings if the next to it is mandatory, because it is expected to appear in that order. Handle unordered groups as well to collect all of the outgoing siblings.