-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm Operator for OpenJ9 JITServer #81
base: master
Are you sure you want to change the base?
Add Helm Operator for OpenJ9 JITServer #81
Conversation
Signed-off-by: Rounak Agarwal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can a user get the two yaml file without cloning this entire openj9-utils repo?
We need some documentation on how to change the Java version for JITServer. Moreover, what happens if a user needs to have a JITServer with Java8 and a JITServer with Java11? We need two different JITServer deployments.
Signed-off-by: Rounak Agarwal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add license information much like the helm files have?
Signed-off-by: Rounak Agarwal <[email protected]>
Signed-off-by: Rounak Agarwal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One I have is about the particle 'sample' in the name of the JITServer service/deployment/pod. E.g. service/openj9jitserverchart-sample-openj9-jitserver-chart
How is the name being constructed?
I also feel there is a bit of redundancy between "openj9jitserverchart" and "openj9-jitserver-chart"
In service.yaml from the jitserver helm chart templates,
Thus, the name translates to |
The |
Signed-off-by: Rounak Agarwal <[email protected]>
Signed-off-by: Rounak Agarwal [email protected]