JITServer Helm Chart for version upgrade to 0.26 #47
Conversation
chrisc66
force-pushed
the
jitserver-helm-chart-0.25
branch
from
470297c
to
e7a71d8
Compare
|
@chrisc66 Docker images with OpenJ9 0.26 have appeared on docker hub |
chrisc66
changed the title
chrisc66
force-pushed
the
jitserver-helm-chart-0.25
branch
3 times, most recently
from
1963371
to
6fa8737
Compare
chrisc66
changed the title
helm-chart/index.yaml
Outdated
| - apiVersion: v2 | ||
| appVersion: 0.26.0 | ||
| created: "2021-03-12T18:49:10.914225842-08:00" | ||
| description: "Eclipse OpenJ9 JITServer Helm Chart. \n\nLicense\n\nThis chart is |
There was a problem hiding this comment.
Why has the license message changed from the 0.24.0 which read:
By installing this product you accept the Eclipse Public License v2.0
There was a problem hiding this comment.
The description has been updated in latest commit.
The previous description was generated by helm, which is copied directly from Chart.yaml.
https://github.com/eclipse-openj9/openj9-utils/blob/master/helm-chart/openj9-jitserver-chart/Chart.yaml#L25
Should we keep these two versions consistent? If yes, could you please confirm which version is desired?
(Chart.yaml)
Eclipse OpenJ9 JITServer Helm Chart.
License
This chart is made available under the terms of the Eclipse Public License 2.0
which accompanies this distribution and is available at https://www.eclipse.org/legal/epl-2.0/
or the Apache License, Version 2.0 which accompanies this distribution and
is available at https://www.apache.org/licenses/LICENSE-2.0.
The JDK binaries installed by this chart are licensed under the GPLv2+CE.(index.yaml)
Eclipse OpenJ9 JITServer Helm Chart.
License
By installing this product you accept the Eclipse Public License v2.0:
https://www.eclipse.org/legal/epl-2.0/.There was a problem hiding this comment.
I see your point now. The license from Chart.yaml seems more comprehensive, but what worries me is that different releases in index.yaml will have different license terms. I am ok with using the more comprehensive version if you update the text for 0.24 as well.
There was a problem hiding this comment.
I have updated the two descriptions in index.yaml to the more comprehensive version. Could you please check again? Thanks.
chrisc66
force-pushed
the
jitserver-helm-chart-0.25
branch
2 times, most recently
from
cc5dede
to
161def3
Compare
This commit upgrades JITServer helm chart to match the latest OpenJ9 application release of 0.26. Signed-off-by: Chris Chong <[email protected]>
chrisc66
force-pushed
the
jitserver-helm-chart-0.25
branch
from
161def3
to
805a478
Compare
This PR updates the JITServer Helm Chart to 0.26 to follow OpenJ9 0.26 release.
Binary Helm Chart: openj9-jitserver-chart-0.26.0.tar.gz
Reference: #46
Signed-off-by: Chris Chong [email protected]