Fix libdir location in pkgconfig files. #3027
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pkgconfig files currently hardcode the library directory as
${prefix}/lib
, but the library installation directory inconfig.mk
is set as${prefix}/lib${LIB_SUFFIX}
. This causes a mismatch between the library installation directory and the pkgconfig file on redhat-based 64-bit systems.This commit remedies the issue for both the Makefile and CMake build by modifying the pkgconfig files to use
CMAKE_INSTALL_LIBDIR
instead oflib
. In the CMake system, this directly reflects the installation path. The Makefiles were modified to replaceCMAKE_INSTALL_LIBDIR
withlib${LIB_SUFFIX}
, matching thelibdir
definition inconfig.mk
and following the pattern used in defining theprefix
.Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make test
with your changes locally?