Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix persist plugin expiry #3016

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

NorbertHeusser
Copy link
Contributor

@NorbertHeusser NorbertHeusser commented Mar 12, 2024

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 83.11688% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 81.23%. Comparing base (09f0395) to head (fa6bb8b).
Report is 4 commits behind head on develop.

Files Patch % Lines
test/unit/broker/persist_read_stubs.c 66.66% 8 Missing ⚠️
test/unit/broker/subs_stubs.c 0.00% 3 Missing ⚠️
plugins/persist-sqlite/base_msgs.c 90.00% 1 Missing ⚠️
src/database.c 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3016      +/-   ##
===========================================
+ Coverage    81.20%   81.23%   +0.02%     
===========================================
  Files          188      188              
  Lines        31733    31767      +34     
===========================================
+ Hits         25769    25806      +37     
+ Misses        5964     5961       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant