Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed form Handling of products #86

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

Sujal7ss
Copy link
Contributor

@Sujal7ss Sujal7ss commented Jun 1, 2024

Description

Before submitting the post request to add product to cart, first varifying that shoesize is selected.

Changes

Shoe size selected or not is checked before submitting the form
Added styles to selected button
Navigated to signup page if user is not logged in

How to test

Try to add a product in cart without selecting the shoe size

fixes #84

@Sujal7ss Sujal7ss marked this pull request as ready for review June 7, 2024 20:28
@Sujal7ss Sujal7ss changed the title Fixed formHandling of products Fixed form Handling of products Jun 7, 2024
@Sujal7ss Sujal7ss changed the title Fixed form Handling of products [BUG]: Fixed form Handling of products Jun 7, 2024
@Sujal7ss Sujal7ss changed the title [BUG]: Fixed form Handling of products feat: Fixed form Handling of products Jun 7, 2024
Copy link
Owner

@dvjsharma dvjsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvjsharma dvjsharma merged commit b96961c into dvjsharma:master Jun 14, 2024
1 of 4 checks passed
@Sujal7ss
Copy link
Contributor Author

Please give the labels @dvjsharma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server Crash due to undefined value is sent to addCart api
2 participants