Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode added using Redux. #57

Closed
wants to merge 6 commits into from
Closed

Dark Mode added using Redux. #57

wants to merge 6 commits into from

Conversation

SwanandD121
Copy link
Contributor

Description

A Dark Mode feature has been added, which includes an interactive toggle button for user convenience.

Changes

  • All UI components have been updated with darker tones to reduce eye strain.
  • The feature automatically detects the browser's theme and adjusts the website's theme accordingly upon loading.

How to test

To test the Dark Mode functionality, click on the sun/moon icon located in the navbar. This will toggle between Dark Mode and Light Mode.

image

Resolves #49

dvjsharma

This comment was marked as resolved.

Copy link
Owner

@dvjsharma dvjsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major changes, PTAL.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We utilize Redux for state management instead of the context API. This would lead to 2 state management practices which is not recommended. Please look for a redux based alternative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We utilize Redux for state management instead of the context API. This would lead to 2 state management practices which is not recommended. Please look for a redux based alternative.

Alright, working on it.

@SwanandD121
Copy link
Contributor Author

Changed the dark mode logic implementation using Redux Toolkit.
Resolved one conflict in Guide component.

Fixed #49

@dvjsharma
Copy link
Owner

Please squash the commits into one so we can track all dark mode related changes together.

Added the dark mode to the website using Redux Toolkit with an interactive toggle button.

Resolved one conflict in Guide component.
@SwanandD121
Copy link
Contributor Author

Please squash the commits into one so we can track all dark mode related changes together.

Done.

Fixed #49

@SwanandD121 SwanandD121 changed the title Dark Mode added. Dark Mode added using Redux. May 18, 2024
Copy link
Owner

@dvjsharma dvjsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks good.
@ShashankShekhar07 Please test with latest master and review

@dvjsharma
Copy link
Owner

Good work @SwanandD121, Please rebase with master

Added the dark mode to the website using Redux Toolkit with an interactive toggle button.

Resolved one conflict in Guide component.
@SwanandD121
Copy link
Contributor Author

SwanandD121 commented May 19, 2024

Good work @SwanandD121, Please rebase with master

Done with rebasing. Resolved 1 conflict.
Other commits came up from the upstream branch while rebasing. Please squash and merge.

Fixed #49

@ShashankShekhar07
Copy link
Collaborator

Hey Well Done @SwanandD121. I think you forgot adding dark mode feature in retailer page. Also the theme button vanishes when the user is logged in. Please see through it.

@SwanandD121
Copy link
Contributor Author

Hey Well Done @SwanandD121. I think you forgot adding dark mode feature in retailer page. Also the theme button vanishes when the user is logged in. Please see through it.

Thanks. I'll check the things you mentioned and get back to you.

@dvjsharma
Copy link
Owner

any updates @SwanandD121?

@SwanandD121
Copy link
Contributor Author

any updates @SwanandD121?

I'm having trouble connecting backend to frontend and running the entire app, I mailed you 3-4 days ago but I haven't heard from you.

@dvjsharma
Copy link
Owner

Will do.
CC @ShashankShekhar07

@dvjsharma dvjsharma mentioned this pull request Jun 1, 2024
@SwanandD121 SwanandD121 closed this by deleting the head repository Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GSSoC'24 label level2 needs test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Dark Mode.
4 participants