-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode added using Redux. #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major changes, PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We utilize Redux for state management instead of the context API. This would lead to 2 state management practices which is not recommended. Please look for a redux based alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We utilize Redux for state management instead of the context API. This would lead to 2 state management practices which is not recommended. Please look for a redux based alternative.
Alright, working on it.
Changed the dark mode logic implementation using Redux Toolkit. Fixed #49 |
Please squash the commits into one so we can track all dark mode related changes together. |
Added the dark mode to the website using Redux Toolkit with an interactive toggle button. Resolved one conflict in Guide component.
Done. Fixed #49 |
fix(ui): removed the arrows in Pincode number input box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Looks good.
@ShashankShekhar07 Please test with latest master and review
Good work @SwanandD121, Please rebase with master |
Added the dark mode to the website using Redux Toolkit with an interactive toggle button. Resolved one conflict in Guide component.
Done with rebasing. Resolved 1 conflict. Fixed #49 |
Hey Well Done @SwanandD121. I think you forgot adding dark mode feature in retailer page. Also the theme button vanishes when the user is logged in. Please see through it. |
Thanks. I'll check the things you mentioned and get back to you. |
any updates @SwanandD121? |
I'm having trouble connecting backend to frontend and running the entire app, I mailed you 3-4 days ago but I haven't heard from you. |
Will do. |
Description
A Dark Mode feature has been added, which includes an interactive toggle button for user convenience.
Changes
How to test
To test the Dark Mode functionality, click on the sun/moon icon located in the navbar. This will toggle between Dark Mode and Light Mode.
Resolves #49