Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Wishlist page #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Saloni1707
Copy link

@Saloni1707 Saloni1707 commented Jul 11, 2024

Wishlist page

#93

Changes

Here's a new feature introduced that enables the user to add & remove products from the Wishlist page .
The user can simply click on the Wishlist option , and do check their wishlisted products.

trim.D9203BC9-DFAB-4314-9107-7AA9B743EAB1.MOV

@dvjsharma
Copy link
Owner

Hey @Saloni1707. Few things

  1. Do fill the PR description and related fields, It's to be populated not to be left blank.
  2. Make sure to include proof of work/screenshots of what you did, since this is a UI PR.
  3. Please change the PR title to pass the tests. feat: added wishlist page.

@Saloni1707 Saloni1707 changed the title Wishlist page added feat: added Wishlist page Jul 11, 2024
@dvjsharma
Copy link
Owner

Looks good @Saloni1707. I can see the user is not signed in when you added the item in wishlist, so there would be no sense to have a list of loved items if the users can't track what they actually saved. Here is what I suggest:

  • Make this option available only after signin.
  • For each user, store the items they have wishlisted (you'll need to make a db change).
  • When the user fetches the list, they should be able to see the complete info of their products, not just the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants