signup ui design fixed #118 #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvjsharma
requested changes
Jul 9, 2024
There was a problem hiding this comment.
We don't use plain CSS. Please migrate to tailwind.
There was a problem hiding this comment.
As I mentioned already, we use tailwind CSS. Please stick to that.
Comment on lines
+62
to
+84
|
|
||
| .signup-card h3 { | ||
| font-size: 2rem; /* Example: Larger font size for headers */ | ||
| margin-bottom: 1.5rem; /* Example: Increased bottom margin */ | ||
| } | ||
|
|
||
| .signup-card .text-center p { | ||
| margin: 0; | ||
| } | ||
|
|
||
| .signup-card .text-center p a { | ||
| text-decoration: none; | ||
| background-color: rgb(74, 181, 74); /* Green background for the Login button */ | ||
| color: white; /* White text color for the Login button */ | ||
| padding: 10px 15px; /* Add some padding */ | ||
| border-radius: 5px; /* Rounded corners */ | ||
| box-shadow: 0 2px 4px rgba(0, 0, 0, 0.1); /* Slight shadow */ | ||
| } | ||
|
|
||
| .signup-card .text-center p a:hover { | ||
| background-color: #004d00; /* Darker green for the Login button on hover */ | ||
| text-decoration: none; /* No underline on hover */ | ||
| } |
Comment on lines
+20
to
+33
| const registerf = async (e) => { | ||
| e.preventDefault(); | ||
| if ( | ||
| !( | ||
| name.length > 0 && | ||
| email.length > 0 && | ||
| passwd.length > 0 && | ||
| street.length > 0 && | ||
| city.length > 0 && | ||
| state.length > 0 && | ||
| pincode.length > 0 | ||
| ) | ||
| ) { | ||
| toast.error("All fields are necessary"); |
There was a problem hiding this comment.
Please look for a better approach than checking the length. (empty functions etc.)
|
Good work with the design tho. Minor suggestion, please see if you can make the purple and blue backgrounds black and white so we can stick to the website theme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#118 issue fixed
Changes
List the changes done to fix a bug or introducing a new feature.
How to test
usign signup button
Please consider using the closing keyword if the pull request is proposed to
fix an issue already created in the repository
(https://help.github.com/articles/closing-issues-using-keywords/)