Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Android 15 (SDK 35) #5204

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Commits on Nov 29, 2024

  1. target sdk 35

    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8f76be2 View commit details
    Browse the repository at this point in the history
  2. Required code changes

    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d70abeb View commit details
    Browse the repository at this point in the history
  3. turn off edgetoedge enforcement

    we can tackle this at a later date
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8c59d55 View commit details
    Browse the repository at this point in the history
  4. update SQLCipher dependency

    The dependency has moved to a new repo: https://github.com/sqlcipher/sqlcipher-android
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    a0d6e46 View commit details
    Browse the repository at this point in the history
  5. migrate SQLCipher code

    SupportFactory -> SupportOpenHelperFactory
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    c688c5f View commit details
    Browse the repository at this point in the history
  6. remove deprecated databaseEnabled

    It's false by default and was only added as protection. Since SQLCipher has supported sqlite 3.26.0 since 4.0.1 (released 2018) this should no longer be a concern in my opinion: https://www.zetetic.net/blog/2018/12/18/sqlcipher-401-release/
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8917aae View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dbb5f87 View commit details
    Browse the repository at this point in the history
  8. fix function collisions

    "The List type in Java is mapped to the MutableList type in Kotlin. Because the List.removeFirst() and List.removeLast() APIs have been introduced in Android 15 (API level 35), the Kotlin compiler resolves function calls, for example list.removeFirst(), statically to the new List APIs instead of to the extension functions in kotlin-stdlib."
    
    Robolectric supports 34 right now so easier that we just change these functions.
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    4f70752 View commit details
    Browse the repository at this point in the history
  9. rename function and use

    The function in this class was not used but we can rename it and use it as it uses the removeAt function which we need due to the collision with the stdlib.
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    39982ef View commit details
    Browse the repository at this point in the history
  10. formatting

    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    030138d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ed1c9a8 View commit details
    Browse the repository at this point in the history