-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target Android 15 (SDK 35) #5204
Draft
mikescamell
wants to merge
11
commits into
develop
Choose a base branch
from
feature/mike/android-15
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Nov 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8f76be2 - Browse repository at this point
Copy the full SHA 8f76be2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d70abeb - Browse repository at this point
Copy the full SHA d70abebView commit details -
turn off edgetoedge enforcement
we can tackle this at a later date
Configuration menu - View commit details
-
Copy full SHA for 8c59d55 - Browse repository at this point
Copy the full SHA 8c59d55View commit details -
The dependency has moved to a new repo: https://github.com/sqlcipher/sqlcipher-android
Configuration menu - View commit details
-
Copy full SHA for a0d6e46 - Browse repository at this point
Copy the full SHA a0d6e46View commit details -
SupportFactory -> SupportOpenHelperFactory
Configuration menu - View commit details
-
Copy full SHA for c688c5f - Browse repository at this point
Copy the full SHA c688c5fView commit details -
remove deprecated databaseEnabled
It's false by default and was only added as protection. Since SQLCipher has supported sqlite 3.26.0 since 4.0.1 (released 2018) this should no longer be a concern in my opinion: https://www.zetetic.net/blog/2018/12/18/sqlcipher-401-release/
Configuration menu - View commit details
-
Copy full SHA for 8917aae - Browse repository at this point
Copy the full SHA 8917aaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbb5f87 - Browse repository at this point
Copy the full SHA dbb5f87View commit details -
"The List type in Java is mapped to the MutableList type in Kotlin. Because the List.removeFirst() and List.removeLast() APIs have been introduced in Android 15 (API level 35), the Kotlin compiler resolves function calls, for example list.removeFirst(), statically to the new List APIs instead of to the extension functions in kotlin-stdlib." Robolectric supports 34 right now so easier that we just change these functions.
Configuration menu - View commit details
-
Copy full SHA for 4f70752 - Browse repository at this point
Copy the full SHA 4f70752View commit details -
The function in this class was not used but we can rename it and use it as it uses the removeAt function which we need due to the collision with the stdlib.
Configuration menu - View commit details
-
Copy full SHA for 39982ef - Browse repository at this point
Copy the full SHA 39982efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 030138d - Browse repository at this point
Copy the full SHA 030138dView commit details -
This version supports sdk 35: https://github.com/robolectric/robolectric/releases/tag/robolectric-4.14
Configuration menu - View commit details
-
Copy full SHA for ed1c9a8 - Browse repository at this point
Copy the full SHA ed1c9a8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.