Truncate export PCAP file on overwrite #4372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Android 10/11, the "w" write mode no longer truncates the file during a file overwrite. More details about this workaround can be found at https://issuetracker.google.com/issues/180526528
|
@karlenDimla can you confirm this works? Assigning it to you, feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: Related to #4371
Description
In Android 10/11, the "w" write mode no longer truncates the file during an overwrite. More details about this workaround can be found at https://issuetracker.google.com/issues/180526528
During the fix for #3069 all other instances of
ContentResolver.open...were reviewed to see if they also used the "w" mode. The only other one was for exporting PCAP files as it usedcontentResolver.openOutputStream(uri)which is a convenience function that callscontentResolver.openOutputStream(uri, "w").Steps to test this PR