Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default behaviour of JOIN and ORDER BY #8

Merged
merged 5 commits into from
Apr 2, 2014
Merged

Default behaviour of JOIN and ORDER BY #8

merged 5 commits into from
Apr 2, 2014

Conversation

oshamin
Copy link
Contributor

@oshamin oshamin commented Apr 2, 2014

No description provided.

@oshamin
Copy link
Contributor Author

oshamin commented Apr 2, 2014

Probably I forgot to use tab for indentation.

@dsferruzza
Copy link
Owner

Thanks!
This looks good to me, except for the indentation.

Could you fix it, please? (It's just a basic Find&Replace, but the diff would be more readable.)
You can also add yourself in the contributors array in package.json, if you wish to.

@oshamin
Copy link
Contributor Author

oshamin commented Apr 2, 2014

Can I create fourth commit with changes or should recommit these three?

@dsferruzza
Copy link
Owner

I think you can just push new commits to your repo, and it will be automatically added to the pull request.

@oshamin
Copy link
Contributor Author

oshamin commented Apr 2, 2014

I made it, please check

@dsferruzza
Copy link
Owner

Thanks a lot!
I will publish a new version to npm and bower soon.

If you want to say something or participate to the v2, please do: #6

dsferruzza added a commit that referenced this pull request Apr 2, 2014
Default behaviour of JOIN and ORDER BY (fixes #7)
@dsferruzza dsferruzza merged commit 2229dba into dsferruzza:master Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants