Make use of containing ROM folder optional #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly useful for distributions where it is not expected for permission to be granted to the directory a ROM is contained in (e.g. Flatpak or other Portal API use). To this end, the `ImGui::Combo` API now uses a list rather that a double null-terminated string as—combined with trailing commas in C++11—this allows for entries in this list to be easily added and removed. Currently, no platform uses this, but this will likely be useful for a contained release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As alluded to in #95, it does not make much sense to provide an option to use a ROM's containing directory as a place to store resources if permission does not exist. This is most likely to happen when using APIs such as the Portal API to gain access to individual files.
It is possible to detect if we are in a contained environment using environment variables, but I feel as though it may introduce unnecessary overhead for something we should likely know ahead of time during build.
I was originally going to have the combo removed altogether if there was only one option, but I decided against it for simplicity of this pull request. This is something I can implement, but I'm notorious for over-engineering, so I would rather push this now.
One area I wish to receive feedback on is the name of the preprocessor directive:
PREVENT_ROM_FOLDER_USAGE. I'm not sure what convention is being used, given that those starting withGS_tend to be focused on the functionality itself rather than the GUI. I'm happy to change this directive's name if it is preferred.