Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]nydusd: support cas gc in umount #1639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner October 23, 2024 15:00
@Desiki-high Desiki-high requested review from imeoer, jiangliu and gaius-qi and removed request for a team October 23, 2024 15:00
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.10%. Comparing base (375f55f) to head (11e9d75).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
- Coverage   60.10%   60.10%   -0.01%     
==========================================
  Files         147      147              
  Lines       49513    49513              
  Branches    46994    46994              
==========================================
- Hits        29762    29760       -2     
- Misses      17970    17971       +1     
- Partials     1781     1782       +1     

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant