-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expand Nydusify to support encrypted Nydus images #1386
base: master
Are you sure you want to change the base?
Conversation
@taoohong , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/88165 |
@taoohong , The CI test is completed, please check result:
Congratulations, your test job passed! |
@taoohong , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/88169 |
@taoohong , The CI test is completed, please check result:
Congratulations, your test job passed! |
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
+ Coverage 46.38% 46.39% +0.01%
==========================================
Files 123 123
Lines 38557 38557
Branches 38557 38557
==========================================
+ Hits 17883 17889 +6
+ Misses 19703 19697 -6
Partials 971 971 |
11d7a57
to
effb37a
Compare
@taoohong , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/89617 |
@taoohong , The CI test is completed, please check result:
Congratulations, your test job passed! |
* convert: generate encrypted Ndyus images from OCI images. * check: check encrypted Nydus images. * mount: mount encrypted Nydus images. * build: build Nydus image with encrypted data blobs from a source directory. Signed-off-by: taohong <[email protected]>
effb37a
to
dcfca7b
Compare
@@ -425,6 +425,13 @@ func main() { | |||
Usage: "File path to save the metrics collected during conversion in JSON format, for example: './output.json'", | |||
EnvVars: []string{"OUTPUT_JSON"}, | |||
}, | |||
&cli.StringSliceFlag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smoke test is required. Please also update doc
@@ -606,6 +614,12 @@ func main() { | |||
Usage: "Path to the nydusd binary, default to search in PATH", | |||
EnvVars: []string{"NYDUSD"}, | |||
}, | |||
&cli.StringSliceFlag{ | |||
Name: "decrypt-keys", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -765,6 +780,12 @@ func main() { | |||
Usage: "The nydusd binary path, if unset, search in PATH environment", | |||
EnvVars: []string{"NYDUSD"}, | |||
}, | |||
&cli.StringSliceFlag{ | |||
Name: "decrypt-keys", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -921,6 +943,14 @@ func main() { | |||
Usage: "Path to the nydus-image binary, default to search in PATH", | |||
EnvVars: []string{"NYDUS_IMAGE"}, | |||
}, | |||
|
|||
&cli.StringSliceFlag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.Related Issue