Edit create_states_mapping function from disk cache to memory cache. #1033
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when using the fixed output format of response_format in vLLM, the same regex_string and tokenizer are repeatedly used to create the
CFGGuide
andRegexGuide
classes and call theirget_next_instruction
methods. During the creation,create_states_mapping
uses thecache
decorator to read the cache from the disk. However, the time spent reading the cache from the disk accounts for most of the total time required forget_next_instruction
. I believe we can speed up this process by changing the cache ofcreate_states_mapping
to be stored in memory.Here's some logs