Fix issue#9807 2nd draft (Replaces PR #11867) DRAFT

[paul1956]

Fixes #9807

Proposed changes

• Add Remove dependance on WebClient for VB FileDownload by using HttpClient
• Upload still uses WebClient that also needs to be done as a separate PR

Customer Impact

• Adds Async file download support to VB, and if WebClient goes away this will allow existing Visual Basic programs using synchronous File Download to still work.
• It also enables Async FileDownload is API is approved

Regression?

• Yes, when WebClient if and when goes away, not today

Risk

• The existing code uses ICredentials in some of the paths, it is unclear how compatible that is between WebClient and HttpClient

• Close to 100% Code Coverage Before and After change, original tests had no tests and there Error Message handling was odd

• There are Exception Messages that need to move from WebClient to this PR and be translated.

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 95.84866% with 79 lines in your changes missing coverage. Please review.

Project coverage is 75.86491%. Comparing base (711dd37) to head (b5da52c).

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #12489         +/-   ##
===================================================
+ Coverage   75.73861%   75.86491%   +0.12630%     
===================================================
  Files           3157        3161          +4     
  Lines         636097      637839       +1742     
  Branches       47002       47076         +74     
===================================================
+ Hits          481771      483896       +2125     
+ Misses        150866      150482        -384     
- Partials        3460        3461          +1     

Flag	Coverage Δ
Debug	75.86491% <95.84866%> (+0.12630%)	⬆️
integration	18.15777% <0.00000%> (-0.02292%)	⬇️
production	49.50592% <85.37037%> (+0.20516%)	⬆️
test	97.05664% <100.00000%> (+0.00992%)	⬆️
unit	46.71097% <85.37037%> (+0.22234%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles