-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for TextBoxBaseDesigner #12433
base: main
Are you sure you want to change the base?
Conversation
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some trailing whitespace that is causing build failure
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider doing a local build from command line to help with catching build errors that CI will produce. This can be done by running build.cmd
from the command line where your local winforms repo lives.
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/TextBoxBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12433 +/- ##
====================================================
+ Coverage 75.65340% 97.04403% +21.39063%
====================================================
Files 3121 1162 -1959
Lines 635411 351966 -283445
Branches 46937 5294 -41643
====================================================
- Hits 480710 341562 -139148
+ Misses 151240 9658 -141582
+ Partials 3461 746 -2715
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow