Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for TextBoxBaseDesigner #12433

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Liv-Goh
Copy link
Contributor

@Liv-Goh Liv-Goh commented Nov 6, 2024

Related #10773

Proposed changes

  1. Add unit test TextBoxBaseDesignerTests.cs for public properties and method of the TextBoxBaseDesigner.
  2. Enable nullability in TextBoxBaseDesignerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@Liv-Goh Liv-Goh requested a review from a team as a code owner November 6, 2024 09:30
@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Nov 7, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Nov 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 8, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some trailing whitespace that is causing build failure

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Nov 8, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 12, 2024
@Liv-Goh Liv-Goh added the 📭 waiting-author-feedback The team requires more information from the author label Nov 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 12, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider doing a local build from command line to help with catching build errors that CI will produce. This can be done by running build.cmd from the command line where your local winforms repo lives.

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Nov 13, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.04403%. Comparing base (65c6beb) to head (9f8f5f3).
Report is 99 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12433          +/-   ##
====================================================
+ Coverage   75.65340%   97.04403%   +21.39063%     
====================================================
  Files           3121        1162        -1959     
  Lines         635411      351966      -283445     
  Branches       46937        5294       -41643     
====================================================
- Hits          480710      341562      -139148     
+ Misses        151240        9658      -141582     
+ Partials        3461         746        -2715     
Flag Coverage Δ
Debug 97.04403% <100.00000%> (+21.39063%) ⬆️
integration ?
production ?
test 97.04403% <100.00000%> (+0.01697%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Nov 18, 2024
@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Nov 18, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 19, 2024
@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants